Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Dec 8, 2010, 00:18 UTC
Message-ID: <4CFECEBB.7060703@ramsay1.demon.co.uk>
In-Reply-To: <201012042222.23384.j6t@kdbg.org>

Johannes Sixt wrote:

Show 17 quoted lines

> On Samstag, 4. Dezember 2010, Ramsay Jones wrote:
>> diff --git a/compat/win32/sys/poll.c b/compat/win32/sys/poll.c
>> index 7e74ebe..708a6c9 100644
>> --- a/compat/win32/sys/poll.c
>> +++ b/compat/win32/sys/poll.c
>> @@ -34,6 +34,9 @@
>>
>>  #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
>>  # define WIN32_NATIVE
>> +# if defined (_MSC_VER)
>> +#  define _WIN32_WINNT 0x0502
>> +# endif
>>  # include <winsock2.h>
>>  # include <windows.h>
>>  # include <io.h>
> 
> Don't you have to do the same in git-compat-util.h?

No. compat/win32/sys/poll.c doesn't include git-compat-util.h (and I don't think it should), so adding it there would not solve the immediate problem. Also, I don't see any reason to restrict the API used by both MinGW and msvc in other parts of git.

ATB, Ramsay Jones