git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Dec 7, 2010, 22:54 UTC
Message-ID
<4CFEBB3E.2060401@ramsay1.demon.co.uk>
In-Reply-To
<20101204204541.GA3170@burratino>
Jonathan Nieder wrote:
Show 12 quoted lines
> Could it make sense to define this at the same time as _GNU_SOURCE et
> al?
> 
> 	#define _ALL_SOURCE 1
> 	#define _GNU_SOURCE 1
> 	#define _BSD_SOURCE 1
> 	#define _NETBSD_SOURCE 1
> 	#define _SGI_SOURCE 1
> 	#define _WIN32_WINNT 0x0502
> 
> Haven't thought carefully about the consequences, though; your patch
> is probably safer.
[Sorry for the late reply, I've been away from email for several days]

This would not fix the compilation errors, since compat/win32/sys/poll.c does not include the git-compat-util.h header file (and I *don't* think it should). ;-)

ATB, Ramsay Jones

Previous: Jonathan NiederNext: Erik Faye-Lund
Message 3 of 8 in “msvc: Fix compilation errors in compat/win32/sys/poll.c”
  1. 01/14 msvc: Fix compilation errors in compat/win32/sys/poll.cRamsay Jones, Dec 4, 2010
  2. Jonathan NiederDec 4, 2010
  3. Ramsay JonesDec 7, 2010
  4. Erik Faye-LundDec 4, 2010
  5. Johannes SixtDec 4, 2010
  6. Ramsay JonesDec 8, 2010
  7. Johannes SixtDec 8, 2010
  8. Johannes SixtDec 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.