Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 8, 2010, 19:42 UTC
Message-ID: <201012082042.06935.j6t@kdbg.org>
In-Reply-To: <4CFECEBB.7060703@ramsay1.demon.co.uk>

On Mittwoch, 8. Dezember 2010, Ramsay Jones wrote:

Show 21 quoted lines

> Johannes Sixt wrote:
> > On Samstag, 4. Dezember 2010, Ramsay Jones wrote:
> >> diff --git a/compat/win32/sys/poll.c b/compat/win32/sys/poll.c
> >> index 7e74ebe..708a6c9 100644
> >> --- a/compat/win32/sys/poll.c
> >> +++ b/compat/win32/sys/poll.c
> >> @@ -34,6 +34,9 @@
> >>
> >>  #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
> >>  # define WIN32_NATIVE
> >> +# if defined (_MSC_VER)
> >> +#  define _WIN32_WINNT 0x0502
> >> +# endif
> >>  # include <winsock2.h>
> >>  # include <windows.h>
> >>  # include <io.h>
> >
> > Don't you have to do the same in git-compat-util.h?
>
> No. compat/win32/sys/poll.c doesn't include git-compat-util.h (and I
> don't think it should),

I know and I agree.

> so adding it there would not solve the immediate 
> problem.

Didn't I say: "do the same..."? :-) So the question remains open. After all, by doing so, you would make sure that the rest of git sees the same API (struct definitions and #defined constants) as compat/win32/sys/poll.c, no?

-- Hannes