git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options

From
Bo Yang <struggleyb.nku@gmail.com>
Date
May 25, 2010, 09:39 UTC
Message-ID
<AANLkTin1Ouo9DsEIp6s6vLVbsXvBps7NooJyMjx5e8e8@mail.gmail.com>
In-Reply-To
<20100525093337.GB32460@coredump.intra.peff.net>
On Tue, May 25, 2010 at 5:33 PM, Jeff King <peff@peff.net> wrote:
Show 15 quoted lines
> On Tue, May 25, 2010 at 05:31:23PM +0800, Bo Yang wrote:
>
>> > I have to admit I don't quite understand from the commit message what
>> > the problem is that this is fixing.
>>
>> Ah, the previous code just call a emit_line for parts of the line, and
>> this commit change this behavior. It firstly compose the different
>> parts into one line and only call a emit_line. This is necessary
>> because each time we call emit_line, there will be a graph prefix
>> output. :)
>
> OK. I understood what it _does_ from the commit message and seeing the
> code, but the missing bit was that calling emit_line would get multiple
> graph prefixes.
>

Hmm, as I design, emit_line will be used for emit a complete line out, so I can add the prefix output code in the emit_line function. And thus, I should make sure, no one call emit_line to just output some strings instead of a complete line...

-- 
Regards!
Bo
----------------------------
My blog: http://blog.morebits.org
Previous: Jeff KingNext: Jeff King
Message 12 of 13 in “Make git log --graph looks better with -p and other diff options”
  1. 0/6 Make git log --graph looks better with -p and other diff optionsBo Yang, May 25, 2010
  2. 1/6 Add a prefix output callback to diff output.Bo Yang, May 25, 2010
  3. 2/6 Output the graph columns at the end of the commit message.Bo Yang, May 25, 2010
  4. 3/6 diff.c: Output the text graph padding before each diff line.Bo Yang, May 25, 2010
  5. 4/6 Emit a whole line once a time.Bo Yang, May 25, 2010
  6. 5/6 Register a callback for graph output.Bo Yang, May 25, 2010
  7. 6/6 Make --color-words work well with --graph.Bo Yang, May 25, 2010
  8. Junio C HamanoMay 26, 2010
  9. Jeff KingMay 25, 2010
  10. Bo YangMay 25, 2010
  11. Jeff KingMay 25, 2010
  12. Bo YangMay 25, 2010
  13. Jeff KingMay 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.