Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options
- From
Bo Yang <struggleyb.nku@gmail.com>
- Date
- May 25, 2010, 09:31 UTC
- Message-ID
- <AANLkTim9pDdz-VU8mGsoEaiv81RepaZT29h_5iAOo4bx@mail.gmail.com>
- In-Reply-To
- <20100525092336.GB30863@coredump.intra.peff.net>
On Tue, May 25, 2010 at 5:23 PM, Jeff King <peff@peff.net> wrote:
Show 17 quoted lines
> On Tue, May 25, 2010 at 05:02:28PM +0800, Bo Yang wrote: > >> From: byang <byang@byang-laptop.(none)> >> >> Rebase for a new master... >> >> Bo Yang (6): >> Add a prefix output callback to diff output. >> Output the graph columns at the end of the commit message. >> diff.c: Output the text graph padding before each diff line. > > These patches look fine to me. > >> Emit a whole line once a time. > > I have to admit I don't quite understand from the commit message what > the problem is that this is fixing.
Ah, the previous code just call a emit_line for parts of the line, and this commit change this behavior. It firstly compose the different parts into one line and only call a emit_line. This is necessary because each time we call emit_line, there will be a graph prefix output. :)
Show 9 quoted lines
>> Register a callback for graph output. > > This one looks fine. > >> Make --color-words work well with --graph. > > Your explanation of the rules for when to output sounds sensible to me, > but I'm not familiar enough with the color-words code to evaluate it > (and I lack the time and sleep to look at it more carefully tonight).
Feel free to give me advice any time when you have some. :)
Regards! Bo
-- My blog: http://blog.morebits.org