From: Bo Yang Date: Tue, 25 May 2010 09:39:18 GMT Subject: Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options Message-ID: In-Reply-To: <20100525093337.GB32460@coredump.intra.peff.net> On Tue, May 25, 2010 at 5:33 PM, Jeff King wrote: > On Tue, May 25, 2010 at 05:31:23PM +0800, Bo Yang wrote: > >> > I have to admit I don't quite understand from the commit message what >> > the problem is that this is fixing. >> >> Ah, the previous code just call a emit_line for parts of the line, and >> this commit change this behavior. It firstly compose the different >> parts into one line and only call a emit_line. This is necessary >> because each time we call emit_line, there will be a graph prefix >> output. :) > > OK. I understood what it _does_ from the commit message and seeing the > code, but the missing bit was that calling emit_line would get multiple > graph prefixes. > Hmm, as I design, emit_line will be used for emit a complete line out, so I can add the prefix output code in the emit_line function. And thus, I should make sure, no one call emit_line to just output some strings instead of a complete line... -- Regards! Bo ---------------------------- My blog: http://blog.morebits.org