git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options

From
Jeff King <peff@peff.net>
Date
May 25, 2010, 09:23 UTC
Message-ID
<20100525092336.GB30863@coredump.intra.peff.net>
In-Reply-To
<1274778154-29976-1-git-send-email-struggleyb.nku@gmail.com>
On Tue, May 25, 2010 at 05:02:28PM +0800, Bo Yang wrote:
Show 8 quoted lines
> From: byang <byang@byang-laptop.(none)>
> 
> Rebase for a new master...
> 
> Bo Yang (6):
>   Add a prefix output callback to diff output.
>   Output the graph columns at the end of the commit message.
>   diff.c: Output the text graph padding before each diff line.
These patches look fine to me.
>   Emit a whole line once a time.

I have to admit I don't quite understand from the commit message what the problem is that this is fixing.

>   Register a callback for graph output.
This one looks fine.
>   Make --color-words work well with --graph.

Your explanation of the rules for when to output sounds sensible to me, but I'm not familiar enough with the color-words code to evaluate it (and I lack the time and sleep to look at it more carefully tonight).

-Peff
Previous: Junio C HamanoNext: Bo Yang
Message 9 of 13 in “Make git log --graph looks better with -p and other diff options”
  1. 0/6 Make git log --graph looks better with -p and other diff optionsBo Yang, May 25, 2010
  2. 1/6 Add a prefix output callback to diff output.Bo Yang, May 25, 2010
  3. 2/6 Output the graph columns at the end of the commit message.Bo Yang, May 25, 2010
  4. 3/6 diff.c: Output the text graph padding before each diff line.Bo Yang, May 25, 2010
  5. 4/6 Emit a whole line once a time.Bo Yang, May 25, 2010
  6. 5/6 Register a callback for graph output.Bo Yang, May 25, 2010
  7. 6/6 Make --color-words work well with --graph.Bo Yang, May 25, 2010
  8. Junio C HamanoMay 26, 2010
  9. Jeff KingMay 25, 2010
  10. Bo YangMay 25, 2010
  11. Jeff KingMay 25, 2010
  12. Bo YangMay 25, 2010
  13. Jeff KingMay 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.