Re: [PATCH next 2/2] Remove python 2.5'isms
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Jun 10, 2010, 07:35 UTC
- Message-ID
- <AANLkTimLiLfGAMLp0n86eCIQFViu4veu0aTL6yuA_8f1@mail.gmail.com>
- In-Reply-To
- <4C1094BF.5070907@drmicha.warpmail.net>
Heya,
On Thu, Jun 10, 2010 at 09:31, Michael J Gruber <git@drmicha.warpmail.net> wrote:
> Note that due to the use of an iterator (which P2.4 has) rather than a > list or set, the expression is just as efficient, i.e. calls > startswith() only as often as necessary.
I like that version a lot better, thanks. And I agree, the check_call replacement code should just be put into it's own function in a similar way, and we should use subprocess if it is available.
-- Cheers, Sverre Rabbelier