git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next 2/2 v2] Remove python 2.5'isms

From
David Ripton <dripton@ripton.net>
Date
Jun 10, 2010, 15:41 UTC
Message-ID
<20100610154114.GC31213@vidar.dreamhost.com>
In-Reply-To
<4C10B02F.9050107@drmicha.warpmail.net>
On 2010.06.10 11:28:15 +0200, Michael J Gruber wrote:
Show 5 quoted lines
> Doesn't P2.4 have
> 
> 	from hashlib import sha1 as _digest
> 
> etc.? I haven't checked for "as".

Hashlib was new in Python 2.5. See the note at the top of: http://docs.python.org/library/hashlib.html

You may have hashlib in your Python 2.4, but if so it's a third-party module, not part of the standard library. You shouldn't rely on everyone having it, when it's so easy to fallback to the sha module.

"import foo as bar" was added in Python 2.0. "as" became a reserved word in Python 2.6.

-- 
David Ripton    dripton@ripton.net
Previous: Michael J GruberNext: Michael J Gruber
Message 9 of 12 in “Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS”
  1. 1/2 Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONSBrandon Casey, Jun 9, 2010
  2. 2/2 Remove python 2.5'ismsBrandon Casey, Jun 9, 2010
  3. Sverre RabbelierJun 9, 2010
  4. Johan HerlandJun 9, 2010
  5. Sverre RabbelierJun 9, 2010
  6. 2/2 Remove python 2.5'ismsBrandon Casey, Jun 10, 2010
  7. Sverre RabbelierJun 10, 2010
  8. Michael J GruberJun 10, 2010
  9. David RiptonJun 10, 2010
  10. Michael J GruberJun 11, 2010
  11. Michael J GruberJun 10, 2010
  12. Sverre RabbelierJun 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.