Re: [PATCH next 2/2 v2] Remove python 2.5'isms

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jun 11, 2010, 13:28 UTC
Message-ID: <4C123A10.6050103@drmicha.warpmail.net>
In-Reply-To: <20100610154114.GC31213@vidar.dreamhost.com>

David Ripton venit, vidit, dixit 10.06.2010 17:41:

Show 13 quoted lines

> On 2010.06.10 11:28:15 +0200, Michael J Gruber wrote:
>> Doesn't P2.4 have
>>
>> 	from hashlib import sha1 as _digest
>>
>> etc.? I haven't checked for "as".
> 
> Hashlib was new in Python 2.5.  See the note at the top of:
> http://docs.python.org/library/hashlib.html
> 
> You may have hashlib in your Python 2.4, but if so it's a third-party
> module, not part of the standard library.  You shouldn't rely on
> everyone having it, when it's so easy to fallback to the sha module.

Well sure, that's why we need the try/except's.

> 
> "import foo as bar" was added in Python 2.0.  "as" became a reserved
> word in Python 2.6.

Thanks!. Then we can use the clean version as suggested above (inside try/except).

Michael