Re: [PATCH next 2/2] Remove python 2.5'isms

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jun 10, 2010, 07:31 UTC
Message-ID: <4C1094BF.5070907@drmicha.warpmail.net>
In-Reply-To: <AANLkTikmdsJwy06WuRwpLEKzZE45VZcvPDDxnW1OCb8K@mail.gmail.com>

Sverre Rabbelier venit, vidit, dixit 09.06.2010 23:28:

Show 9 quoted lines

> Heya,
> 
> On Wed, Jun 9, 2010 at 23:24, Brandon Casey <casey@nrlssc.navy.mil> wrote:
>> The following python 2.5 features were worked around:
> 
> Thanks for fixing this, although it makes me sad to see the code
> uglify the way it has :P. I guess that's the pain of backwards
> compatibility.
>

I doesn't need to be ugly. Why not put the Popen thing in a def somewhere? Is there any remaining uglyness besides this:

-    return any(url.startswith(i) for i in prefixes)
+    for prefix in prefixes:
+        if url.startswith(prefix):
+            return True
+    return False

Pythonish version:
-    return any(url.startswith(i) for i in prefixes)
+    return True in (url.startswith(i) for i in prefixes)

Note that due to the use of an iterator (which P2.4 has) rather than a list or set, the expression is just as efficient, i.e. calls startswith() only as often as necessary.

Michael