Re: [PATCH] test-lib: make test_expect_code a test command

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 1, 2010, 17:39 UTC
Message-ID: <AANLkTim1_Zfbrt4G_S2hj1zfF0VX-fM1AkwFyPp0B1qE@mail.gmail.com>
In-Reply-To: <1285953391-29840-1-git-send-email-avarab@gmail.com>

Heya,

On Fri, Oct 1, 2010 at 19:16, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> converted that code to use an external test similar no the TODO test I

s/no/to/

Show 15 quoted lines

> +cat >expect <<EOF &&
> +not ok - 1 tests clean up even after a failure
> +#
> +#          touch clean-after-failure &&
> +#          test_when_finished rm clean-after-failure &&
> +#          (exit 1)
> +#
> +not ok - 2 failure to clean up causes the test to fail
> +#
> +#          test_when_finished \"(exit 2)\"
> +#
> +# failed 2 among 2 test(s)
> +1..2
> +EOF
> +    test_cmp expect out)

I still like the putting-the-code-in-a-separate-harness, but I'm wondering if we can't come up with something better than comparing with test output that could change in the future... unless we decide to standardize on TAP and not deviate from it? Either case, wouldn't it at least be a good idea to get rid of the parts after the # in the comparrison?

-- 
Cheers,

Sverre Rabbelier