Re: [PATCHv4 09/15] t5602 (clone-remote-exec): add missing &&
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 29, 2010, 19:09 UTC
- Message-ID
- <7vzkv0mkn5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1285542879-16381-10-git-send-email-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 29 quoted lines
> Also add a couple test_must_fail invocations where needed. > > Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > Signed-off-by: Elijah Newren <newren@gmail.com> > --- > t/t5602-clone-remote-exec.sh | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/t/t5602-clone-remote-exec.sh b/t/t5602-clone-remote-exec.sh > index deffdae..6aa6e0d 100755 > --- a/t/t5602-clone-remote-exec.sh > +++ b/t/t5602-clone-remote-exec.sh > @@ -5,21 +5,21 @@ test_description=clone > . ./test-lib.sh > > test_expect_success setup ' > - echo "#!/bin/sh" > not_ssh > - echo "echo \"\$*\" > not_ssh_output" >> not_ssh > - echo "exit 1" >> not_ssh > + echo "#!/bin/sh" > not_ssh && > + echo "echo \"\$*\" > not_ssh_output" >> not_ssh && > + echo "exit 1" >> not_ssh && > chmod +x not_ssh > ' > > test_expect_success 'clone calls git upload-pack unqualified with no -u option' ' > - GIT_SSH=./not_ssh git clone localhost:/path/to/repo junk > - echo "localhost git-upload-pack '\''/path/to/repo'\''" >expected > + GIT_SSH=./not_ssh test_must_fail git clone localhost:/path/to/repo junk &&
I think this suffers from the same issue that have been fixed with 09b78bc (t7502-commit.sh: rearrange test to make more portable, 2008-07-22) and 2d60615 (tests: Avoid single-shot environment export for shell function invocation, 2009-01-26).
Show 8 quoted lines
> + echo "localhost git-upload-pack '\''/path/to/repo'\''" >expected && > test_cmp expected not_ssh_output > ' > > test_expect_success 'clone calls specified git upload-pack with -u option' ' > - GIT_SSH=./not_ssh git clone -u ./something/bin/git-upload-pack localhost:/path/to/repo junk > - echo "localhost ./something/bin/git-upload-pack '\''/path/to/repo'\''" >expected > + GIT_SSH=./not_ssh test_must_fail git clone -u ./something/bin/git-upload-pack localhost:/path/to/repo junk &&
So does this.
Show 6 quoted lines
> + echo "localhost ./something/bin/git-upload-pack '\''/path/to/repo'\''" >expected && > test_cmp expected not_ssh_output > ' > > -- > 1.7.3.95.g14291