Re: [PATCHv4 07/15] t4019 (diff-wserror): add lots of missing &&
- From
Elijah Newren <newren@gmail.com>
- Date
- Oct 3, 2010, 03:03 UTC
- Message-ID
- <AANLkTikmf7NSC+ZDRr3tyK=6NdJnWPaE2KLRdZAJu1a-@mail.gmail.com>
- In-Reply-To
- <7v4od8nzl9.fsf@alter.siamese.dyndns.org>
Hi,
On Wed, Sep 29, 2010 at 1:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>> Also add a test_might_fail in front of the final git_config --unset >> core.whitespace as that value may have already been unset previously. > > In general, if a previous one that is designed to set a variable failed > for whatever reason, the next one that does --unset without might-fail > will be broken. So... >
[...]
>> + git config --unset core.whitespace && > > ... I think you need might-fail in front of this one, and ...
[...]
Show 17 quoted lines
> >> + echo "F whitespace=-space" >.gitattributes && >> + prepare_output && >> >> grep Eight normal >/dev/null && >> grep HT normal >/dev/null && >> @@ -107,9 +107,9 @@ test_expect_success 'without -space (attribute)' ' >> >> test_expect_success 'with indent-non-tab only' ' >> >> - rm -f .gitattributes >> - git config core.whitespace indent,-trailing,-space >> - prepare_output >> + rm -f .gitattributes && >> + git config core.whitespace indent,-trailing,-space && > > ... this one, ...
I fixed the others you pointed out, but elsewhere you were talking about git config --unset and the --unset option is not being used here. Is there another reason this config command needs one?