git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv6 09/10] gitweb: provide a routine to display (sub)sections

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Oct 25, 2010, 18:21 UTC
Message-ID
<AANLkTikjGz4LpsneTnJJfyFphUxCfOMa_haG6o9tPUEP@mail.gmail.com>
In-Reply-To
<201010251715.54531.jnareb@gmail.com>
2010/10/25 Jakub Narebski <jnareb@gmail.com>:
Show 15 quoted lines
> On Sun, 24 Oct 2010, Giuseppe Bilotta wrote:
>
> [...]
>> +# Group output by placing it in a DIV element and adding a header.
>> +# Options for start_div() can be provided by passing a hash reference as the
>> +# first parameter to the function.
>> +# Options to git_print_header_div() can be provided by passing an array
>> +# reference. This must follow the options to start_div if they are present.
>> +# The content can be a scalar, which is output as-is, a scalar reference, which
>> +# is output after html escaping, an IO handle passed either as *handle or
>> +# *handle{IO}, or a function reference. In the latter case all following
>> +# parameters will be taken as argument to the content function call.
>> +sub git_print_section {
>
> Very nice API.  Good work!

I'm glad you like it. And thank you very much for the reviews that took me to design it properly. Shall I take this as an ack for the series, modulo the minor suggestions for the other two patches? (Just to know if I can include Junio in the next posting)

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Giuseppe Bilotta
Message 20 of 33 in “[PATCHv6 00/10] gitweb: remote_heads feature”
  1. Giuseppe BilottaOct 24, 2010
  2. 01/10 gitweb: introduce remote_heads featureGiuseppe Bilotta, Oct 24, 2010
  3. 02/10 gitweb: git_get_heads_list accepts an optional list of refs.Giuseppe Bilotta, Oct 24, 2010
  4. Jakub NarebskiOct 25, 2010
  5. Giuseppe BilottaOct 26, 2010
  6. 03/10 gitweb: separate heads and remotes listsGiuseppe Bilotta, Oct 24, 2010
  7. Jakub NarebskiOct 25, 2010
  8. Giuseppe BilottaOct 25, 2010
  9. 04/10 gitweb: nagivation menu for tags, heads and remotesGiuseppe Bilotta, Oct 24, 2010
  10. 05/10 gitweb: use fullname as hash_base in heads linkGiuseppe Bilotta, Oct 24, 2010
  11. Jakub NarebskiOct 25, 2010
  12. Giuseppe BilottaOct 25, 2010
  13. 06/10 gitweb: allow action specialization in page headerGiuseppe Bilotta, Oct 24, 2010
  14. 07/10 gitweb: remotes view for a single remoteGiuseppe Bilotta, Oct 24, 2010
  15. Jakub NarebskiOct 25, 2010
  16. Giuseppe BilottaOct 25, 2010
  17. 08/10 gitweb: refactor repository URL printingGiuseppe Bilotta, Oct 24, 2010
  18. 09/10 gitweb: provide a routine to display (sub)sectionsGiuseppe Bilotta, Oct 24, 2010
  19. Jakub NarebskiOct 25, 2010
  20. Giuseppe BilottaOct 25, 2010
  21. 10/10 gitweb: group remote heads by remoteGiuseppe Bilotta, Oct 24, 2010
  22. Jakub NarebskiOct 27, 2010
  23. Jakub NarebskiOct 27, 2010
  24. Giuseppe BilottaNov 2, 2010
  25. Jakub NarebskiNov 2, 2010
  26. Giuseppe BilottaNov 3, 2010
  27. Jakub NarebskiNov 4, 2010
  28. Giuseppe BilottaNov 8, 2010
  29. Jakub NarebskiNov 8, 2010
  30. Giuseppe BilottaNov 8, 2010
  31. Jakub NarebskiNov 8, 2010
  32. Jakub NarebskiOct 27, 2010
  33. Jakub NarebskiOct 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.