Re: [PATCHv6 05/10] gitweb: use fullname as hash_base in heads link
On Sun, 24 Oct 2010, Giuseppe Bilotta wrote:
> Otherwise, if names are manipulated for display, the link will point to
> the wrong head.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Shouldn't this patch be at beginning, as first patch of the series?
Show 21 quoted lines
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f4592ad..a381892 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4991,7 +4991,7 @@ sub git_heads_body {
> "<td class=\"link\">" .
> $cgi->a({-href => href(action=>"shortlog", hash=>$ref{'fullname'})}, "shortlog") . " | " .
> $cgi->a({-href => href(action=>"log", hash=>$ref{'fullname'})}, "log") . " | " .
> - $cgi->a({-href => href(action=>"tree", hash=>$ref{'fullname'}, hash_base=>$ref{'name'})}, "tree") .
> + $cgi->a({-href => href(action=>"tree", hash=>$ref{'fullname'}, hash_base=>$ref{'fullname'})}, "tree") .
> "</td>\n" .
> "</tr>";
> }
> --
> 1.7.3.68.g6ec8
>
> --
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>