Re: [PATCHv6 02/10] gitweb: git_get_heads_list accepts an optional list of refs.
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Oct 25, 2010, 21:56 UTC
- Message-ID
- <201010252356.37472.jnareb@gmail.com>
- In-Reply-To
- <1287917136-26103-3-git-send-email-giuseppe.bilotta@gmail.com>
On Sun, 24 Sep 2010, Giuseppe Bilotta wrote:
Show 7 quoted lines
> sub git_get_heads_list {
> - my $limit = shift;
> + my ($limit, @classes) = @_;
> + unless (defined @classes) {
> + my $remote_heads = gitweb_check_feature('remote_heads');
> + @classes = ('heads', $remote_heads ? 'remotes' : ());
> + }defined(@array) is deprecated at t/../gitweb/gitweb.perl line 3221.
Should be simply 'unless (@classes)', or 'unless (scalar @classes)' but conditionals provide boolean context, which is scalar context.
I'm sorry about missing it earlier.
-- Jakub Narebski Poland