Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 13, 2010, 21:39 UTC
- Message-ID
- <AANLkTikP5xsvfBt7Rq9CoNnF=7SE4-V6LBML=tDMtT_Q@mail.gmail.com>
- In-Reply-To
- <1281734852-21413-1-git-send-email-ComputerDruid@gmail.com>
On Fri, Aug 13, 2010 at 21:27, Daniel Johnson <computerdruid@gmail.com> wrote:
Show 9 quoted lines
> --- >>> @@ -0,0 +1,44 @@ >>> + >>> +#!/bin/sh >> >> Is that an empty line before the test begins? The shebang should be on >> the first line. > Embarrassing. That's what I get for using yank/put and not paying closer > attention. The rest is fixed too.
Nice, I haven't actually *run it* but it looks good, so provided that it passes tests when our beloved maintainer applies it:
Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>