git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden

From
Daniel Johnson <computerdruid@gmail.com>
Date
Aug 13, 2010, 21:27 UTC
Message-ID
<1281734852-21413-1-git-send-email-ComputerDruid@gmail.com>
In-Reply-To
<AANLkTimYm+GmJ4BmZKOmcZkJf_wgeUiKhTs06qxex+0q@mail.gmail.com>
---
Show 6 quoted lines
>> @@ -0,0 +1,44 @@
>> +
>> +#!/bin/sh
>
> Is that an empty line before the test begins? The shebang should be on
> the first line.

Embarrassing. That's what I get for using yank/put and not paying closer attention. The rest is fixed too.

 t/t5525-fetch-tagopt.sh |   41 +++++++++++++++++++++++++++++++++++++++++
 1 files changed, 41 insertions(+), 0 deletions(-)
 create mode 100755 t/t5525-fetch-tagopt.sh
diff --git a/t/t5525-fetch-tagopt.sh b/t/t5525-fetch-tagopt.sh
new file mode 100755
index 0000000..4fbf7a1
--- /dev/null
+++ b/t/t5525-fetch-tagopt.sh
@@ -0,0 +1,41 @@
+#!/bin/sh
+
+test_description='tagopt variable affects "git fetch" and is overridden by commandline.'
+
+. ./test-lib.sh
+
+setup_clone () {
+	git clone --mirror . $1 &&
+	git remote add remote_$1 $1 &&
+	(cd $1 &&
+	git tag tag_$1)
+}
+
+test_expect_success setup '
+	test_commit test &&
+	setup_clone one &&
+	git config remote.remote_one.tagopt --no-tags &&
+	setup_clone two &&
+	git config remote.remote_two.tagopt --tags
+	'
+
+test_expect_success "fetch with tagopt=--no-tags does not get tag" '
+	git fetch remote_one &&
+	test_must_fail git show-ref tag_one
+	'
+
+test_expect_success "fetch --tags with tagopt=--no-tags gets tag" '
+	git fetch --tags remote_one &&
+	git show-ref tag_one
+	'
+
+test_expect_success "fetch --no-tags with tagopt=--tags does not get tag" '
+	git fetch --no-tags remote_two &&
+	test_must_fail git show-ref tag_two
+	'
+
+test_expect_success "fetch with tagopt=--tags gets tag" '
+	git fetch remote_two &&
+	git show-ref tag_two
+	'
+test_done
-- 
1.7.2
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 9 of 12 in “fetch: allow command line --tags to override config”
  1. fetch: allow command line --tags to override configDaniel Johnson, Aug 4, 2010
  2. Tay Ray ChuanAug 5, 2010
  3. Documentation: changes in the behavior of tagoptDaniel Johnson, Aug 6, 2010
  4. Tay Ray ChuanAug 8, 2010
  5. [RFC/PATCHv2] fetch: allow command line --tags to override configDaniel Johnson, Aug 11, 2010
  6. Junio C HamanoAug 13, 2010
  7. t5525: test the tagopt variable and that it can be overriddenDaniel Johnson, Aug 13, 2010
  8. Ævar Arnfjörð BjarmasonAug 13, 2010
  9. [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overriddenDaniel Johnson, Aug 13, 2010
  10. Ævar Arnfjörð BjarmasonAug 13, 2010
  11. Daniel JohnsonAug 14, 2010
  12. Ævar Arnfjörð BjarmasonAug 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.