git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden

From
Daniel Johnson <computerdruid@gmail.com>
Date
Aug 14, 2010, 21:32 UTC
Message-ID
<201008141732.16214.ComputerDruid@gmail.com>
In-Reply-To
<AANLkTikP5xsvfBt7Rq9CoNnF=7SE4-V6LBML=tDMtT_Q@mail.gmail.com>
On Friday 13 August 2010 17:39:04 Ævar Arnfjörð Bjarmason wrote:
> On Fri, Aug 13, 2010 at 21:27, Daniel Johnson <computerdruid@gmail.com> 
wrote:
Show 16 quoted lines
> > ---
> > 
> >>> @@ -0,0 +1,44 @@
> >>> +
> >>> +#!/bin/sh
> >> 
> >> Is that an empty line before the test begins? The shebang should be on
> >> the first line.
> > 
> > Embarrassing. That's what I get for using yank/put and not paying closer
> > attention. The rest is fixed too.
> 
> Nice, I haven't actually *run it* but it looks good, so provided that
> it passes tests when our beloved maintainer applies it:
> 
> Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Well, now that we have a fix and a test to help guard against future breakages, can someone tell me the next step as to getting them included?

Thanks, -Dan

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 11 of 12 in “fetch: allow command line --tags to override config”
  1. fetch: allow command line --tags to override configDaniel Johnson, Aug 4, 2010
  2. Tay Ray ChuanAug 5, 2010
  3. Documentation: changes in the behavior of tagoptDaniel Johnson, Aug 6, 2010
  4. Tay Ray ChuanAug 8, 2010
  5. [RFC/PATCHv2] fetch: allow command line --tags to override configDaniel Johnson, Aug 11, 2010
  6. Junio C HamanoAug 13, 2010
  7. t5525: test the tagopt variable and that it can be overriddenDaniel Johnson, Aug 13, 2010
  8. Ævar Arnfjörð BjarmasonAug 13, 2010
  9. [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overriddenDaniel Johnson, Aug 13, 2010
  10. Ævar Arnfjörð BjarmasonAug 13, 2010
  11. Daniel JohnsonAug 14, 2010
  12. Ævar Arnfjörð BjarmasonAug 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.