From: Ævar Arnfjörð Bjarmason Date: Fri, 13 Aug 2010 21:39:04 GMT Subject: Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden Message-ID: In-Reply-To: <1281734852-21413-1-git-send-email-ComputerDruid@gmail.com> On Fri, Aug 13, 2010 at 21:27, Daniel Johnson wrote: > --- >>> @@ -0,0 +1,44 @@ >>> + >>> +#!/bin/sh >> >> Is that an empty line before the test begins? The shebang should be on >> the first line. > Embarrassing. That's what I get for using yank/put and not paying closer > attention. The rest is fixed too. Nice, I haven't actually *run it* but it looks good, so provided that it passes tests when our beloved maintainer applies it: Reviewed-by: Ævar Arnfjörð Bjarmason