Re: [PATCH 12/15] gettextize: git-revert mark the "me" variable for translation

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 6, 2010, 20:06 UTC
Message-ID: <AANLkTik2aEYxgpL6QuhbacMv6i2hTNjJ1+0bFdK4tph-@mail.gmail.com>
In-Reply-To: <20100906184536.GD25426@burratino>

On Mon, Sep 6, 2010 at 18:45, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 7 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>
>> The "me" variable is used in many later messages to indicate whether
>> we're using revert or cherry-pick.
>
> What good does it do to translate it?  The command name is the same
> even in Hindi git.

Not all uses of it are references to git-%s, e.g. in the next patch:

    die(_("Your local changes would be overwritten by %s.\n"), _(me));

But maybe it's used in enough contexts for it to be useless to translate it like this, i.e. we'll have to fix it later, but we'll see about that.

Show 14 quoted lines

>> --- a/builtin/revert.c
>> +++ b/builtin/revert.c
>> @@ -552,7 +552,9 @@ static int revert_or_cherry_pick(int argc, const char **argv)
>>       struct rev_info revs;
>>
>>       git_config(git_default_config, NULL);
>> -     me = action == REVERT ? "revert" : "cherry-pick";
>> +     /* TRANSLATORS: This is used in several error messages indicating
>> +        the name of the current program */
>> +     me = action == REVERT ? N_("revert") : N_("cherry-pick");
>>       setenv(GIT_REFLOG_ACTION, me, 0);
>
> Unrelated question: Are reflog actions supposed to be translated?  (I
> have not thought about that carefully.)

In this updated series I've explicitly reverted patches that (accidentally) translated some of the reflog.

I'm only translating things which'll be viewed by human eyes, and human eyes alone. That doesn't apply to the reflog, which I see as plumbing.