git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/15] gettextize: git-revert split up "could not revert/apply" message

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 6, 2010, 12:21 UTC
Message-ID
<1283775704-29440-15-git-send-email-avarab@gmail.com>
In-Reply-To
<1283638229-14199-1-git-send-email-avarab@gmail.com>

Split up the "could not %s %s... %s" message into "could not revert %s... %s" and "could not apply %s... %s". This makes it easier for translators to understand the message.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/revert.c                |    5 +++--
 t/t3507-cherry-pick-conflict.sh |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c
index 8dff244..7157ee1 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -510,8 +510,9 @@ static int do_pick_commit(void)
 	}
 
 	if (res) {
-		error("could not %s %s... %s",
-		      action == REVERT ? "revert" : "apply",
+		error(action == REVERT
+		      ? _("could not revert %s... %s")
+		      : _("could not apply %s... %s"),
 		      find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
 		      msg.subject);
 		print_advice();
diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh
index 607bf25..bf664ec 100755
--- a/t/t3507-cherry-pick-conflict.sh
+++ b/t/t3507-cherry-pick-conflict.sh
@@ -38,7 +38,7 @@ test_expect_success 'failed cherry-pick does not advance HEAD' '
 	test "$head" = "$newhead"
 '
 
-test_expect_success 'advice from failed cherry-pick' "
+test_expect_success NO_GETTEXT_POISON 'advice from failed cherry-pick' "
 	git checkout -f initial^0 &&
 	git read-tree -u --reset HEAD &&
 	git clean -d -f -f -q -x &&
-- 
1.7.2.3.313.gcd15
Previous: Junio C HamanoNext: Jonathan Nieder
Message 33 of 39 in “[REDO] Add gettext support to Git”
  1. 00/63 [REDO] Add gettext support to GitÆvar Arnfjörð Bjarmason, Sep 4, 2010
  2. 01/63 builtin: use builtin.h for all builtin commandsÆvar Arnfjörð Bjarmason, Sep 4, 2010
  3. 02/63 Add infrastructure for translating Git with gettextÆvar Arnfjörð Bjarmason, Sep 4, 2010
  4. 05/63 tests: locate i18n lib&data correctly under --valgrindÆvar Arnfjörð Bjarmason, Sep 4, 2010
  5. 21/63 po/is.po: add Icelandic translationÆvar Arnfjörð Bjarmason, Sep 4, 2010
  6. 26/63 gettext tests: add GETTEXT_POISON=YesPlease Makefile parameterÆvar Arnfjörð Bjarmason, Sep 4, 2010
  7. 27/63 gettext tests: skip lib-gettext.sh tests under GETTEXT_POISONÆvar Arnfjörð Bjarmason, Sep 4, 2010
  8. 28/63 gettext tests: skip breaking tests under GETTEXT_POISONÆvar Arnfjörð Bjarmason, Sep 4, 2010
  9. 51/63 gettextize: git-merge basic messagesÆvar Arnfjörð Bjarmason, Sep 4, 2010
  10. 63/63 po/en_GB.po: add British English TranslationÆvar Arnfjörð Bjarmason, Sep 4, 2010
  11. 00/15 [REDO CONTINUE] Add gettext support to GitÆvar Arnfjörð Bjarmason, Sep 6, 2010
  12. 01/15 gettextize: git-archive basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  13. 02/15 gettextize: git-bundle basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  14. 03/15 gettextize: git-clean basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  15. 04/15 gettextize: git-clean clean.requireForce messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  16. 05/15 gettextize: git-describe basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  17. 06/15 gettextize: git-gc basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  18. 07/15 gettextize: git-gc "Auto packing the repository" messageÆvar Arnfjörð Bjarmason, Sep 6, 2010
  19. 08/15 gettextize: git-notes basic commandsÆvar Arnfjörð Bjarmason, Sep 6, 2010
  20. 09/15 gettextize: git-notes GIT_NOTES_REWRITE_MODE error messageÆvar Arnfjörð Bjarmason, Sep 6, 2010
  21. 10/15 gettextize: git-notes "Refusing to %s notes in %s" messageÆvar Arnfjörð Bjarmason, Sep 6, 2010
  22. 11/15 gettextize: git-revert basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  23. 12/15 gettextize: git-revert mark the "me" variable for translationÆvar Arnfjörð Bjarmason, Sep 6, 2010
  24. Jonathan NiederSep 6, 2010
  25. Ævar Arnfjörð BjarmasonSep 6, 2010
  26. Jonathan NiederSep 6, 2010
  27. 13/15 gettextize: git-revert messages using the "me" variableÆvar Arnfjörð Bjarmason, Sep 6, 2010
  28. Jonathan NiederSep 6, 2010
  29. Ævar Arnfjörð BjarmasonSep 6, 2010
  30. Jonathan NiederSep 7, 2010
  31. Ævar Arnfjörð BjarmasonSep 7, 2010
  32. Junio C HamanoSep 10, 2010
  33. 14/15 gettextize: git-revert split up "could not revert/apply" messageÆvar Arnfjörð Bjarmason, Sep 6, 2010
  34. Jonathan NiederSep 6, 2010
  35. Ævar Arnfjörð BjarmasonSep 6, 2010
  36. Jonathan NiederSep 7, 2010
  37. Ævar Arnfjörð BjarmasonSep 7, 2010
  38. 15/15 gettextize: git-shortlog basic messagesÆvar Arnfjörð Bjarmason, Sep 6, 2010
  39. Jonathan NiederSep 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.