Re: [PATCH 12/15] gettextize: git-revert mark the "me" variable for translation

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 6, 2010, 18:45 UTC
Message-ID: <20100906184536.GD25426@burratino>
In-Reply-To: <1283775704-29440-13-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> The "me" variable is used in many later messages to indicate whether
> we're using revert or cherry-pick.

What good does it do to translate it? The command name is the same even in Hindi git.

Show 11 quoted lines

> --- a/builtin/revert.c
> +++ b/builtin/revert.c
> @@ -552,7 +552,9 @@ static int revert_or_cherry_pick(int argc, const char **argv)
>  	struct rev_info revs;
>  
>  	git_config(git_default_config, NULL);
> -	me = action == REVERT ? "revert" : "cherry-pick";
> +	/* TRANSLATORS: This is used in several error messages indicating
> +	   the name of the current program */
> +	me = action == REVERT ? N_("revert") : N_("cherry-pick");
>  	setenv(GIT_REFLOG_ACTION, me, 0);

Unrelated question: Are reflog actions supposed to be translated? (I have not thought about that carefully.)