git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t/t5800: skip if python version is older than 2.5

From
Brandon Casey <drafnel@gmail.com>
Date
Aug 18, 2010, 02:37 UTC
Message-ID
<AANLkTi=y5vr25cJMfV=7KisCB7R-s7YVonc-7QZemO0j@mail.gmail.com>
In-Reply-To
<AANLkTim+YQHxkY6WWF4Yfo74jZnAE8ufdnabp9mneBgu@mail.gmail.com>
On Tue, Aug 17, 2010 at 7:10 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 6 quoted lines
> Heya,
>
> On Tue, Aug 17, 2010 at 18:37, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> I see.  Maybe this is fixed by v1.7.2-rc0~33^2~1 (Makefile: add
>> PYTHON_PATH to GIT-BUILD-OPTIONS, 2010-06-09) from later in the
>> same series.

Well not actually the same series. If I recall correctly, the original version of this 'skip if python vers...' patch was replaced by a resend of two patches and one of them did the' propagate PYTHON_PATH to GIT-BUILD-OPTIONS' thing.

I think Junio ended up fixing up the original patch by hand, and the PYTHON_PATH bit got dropped.

Later on I resent it.
> Ah, correct. So that should have gone before this one. It works if I
> check out and build that one. Thanks.

Also, note that the test should complete successfully if run via 'make test' since PYTHON_PATH is exported in the Makefile. That's why I didn't notice the flaw at first.

-Brandon
Previous: Sverre RabbelierNext: Johannes Sixt
Message 17 of 31 in “miscellaneous test suite fixes”
  1. 0/5 miscellaneous test suite fixesBrandon Casey, Jun 2, 2010
  2. 1/5 t/t5800: skip if python version is older than 2.5Brandon Casey, Jun 2, 2010
  3. Sverre RabbelierJun 2, 2010
  4. Ævar Arnfjörð BjarmasonJun 2, 2010
  5. Brandon CaseyJun 2, 2010
  6. Brandon CaseyJun 2, 2010
  7. Sverre RabbelierJun 2, 2010
  8. Brandon CaseyJun 2, 2010
  9. test suite work-around for python 2.5 requirementBrandon Casey, Jun 2, 2010
  10. 1/2 Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONSBrandon Casey, Jun 2, 2010
  11. 2/2 t/t5800: skip if python version is older than 2.5Brandon Casey, Jun 2, 2010
  12. Sverre RabbelierAug 17, 2010
  13. Jonathan NiederAug 17, 2010
  14. Sverre RabbelierAug 17, 2010
  15. Jonathan NiederAug 17, 2010
  16. Sverre RabbelierAug 18, 2010
  17. Brandon CaseyAug 18, 2010
  18. Johannes SixtJun 2, 2010
  19. Brandon CaseyJun 2, 2010
  20. 2/5 git-request-pull.sh: remove -e switch to shell interpreter which breaks kshBrandon Casey, Jun 2, 2010
  21. Jonathan NiederJun 2, 2010
  22. Brandon CaseyJun 2, 2010
  23. Junio C HamanoJun 2, 2010
  24. 3/5 t/t5150: remove space from sed scriptBrandon Casey, Jun 2, 2010
  25. Jonathan NiederJun 2, 2010
  26. 4/5 t/t7006: ignore return status of shell's unset builtinBrandon Casey, Jun 2, 2010
  27. Jonathan NiederJun 2, 2010
  28. Johannes SixtJun 2, 2010
  29. Brandon CaseyJun 2, 2010
  30. 4/5 t/t7006: ignore return status of shell's unset builtinBrandon Casey, Jun 2, 2010
  31. 5/5 t/aggregate-results: accomodate systems with small max argument list lengthBrandon Casey, Jun 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.