From: Brandon Casey <drafnel@gmail.com>
Date: Wed, 18 Aug 2010 02:37:26 GMT
Subject: Re: [PATCH 2/2] t/t5800: skip if python version is older than 2.5
Message-ID: <AANLkTi=y5vr25cJMfV=7KisCB7R-s7YVonc-7QZemO0j@mail.gmail.com>
In-Reply-To: <AANLkTim+YQHxkY6WWF4Yfo74jZnAE8ufdnabp9mneBgu@mail.gmail.com>

On Tue, Aug 17, 2010 at 7:10 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Heya,
>
> On Tue, Aug 17, 2010 at 18:37, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> I see.  Maybe this is fixed by v1.7.2-rc0~33^2~1 (Makefile: add
>> PYTHON_PATH to GIT-BUILD-OPTIONS, 2010-06-09) from later in the
>> same series.

Well not actually the same series.  If I recall correctly, the
original version of
this 'skip if python vers...' patch was replaced by a resend of two patches and
one of them did the' propagate PYTHON_PATH to GIT-BUILD-OPTIONS' thing.

I think Junio ended up fixing up the original patch by hand, and the PYTHON_PATH
bit got dropped.

Later on I resent it.

> Ah, correct. So that should have gone before this one. It works if I
> check out and build that one. Thanks.

Also, note that the test should complete successfully if run via 'make
test' since
PYTHON_PATH is exported in the Makefile.  That's why I didn't notice the
flaw at first.

-Brandon