Re: [PATCH 2/5] git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh
On 06/01/2010 11:30 PM, Jonathan Nieder wrote:
Show 21 quoted lines
> Brandon Casey wrote:
>
>> When git-request-pull was originally written, it did not do any error
>> checking and it used this shell feature to exit when an error occurred.
>> This script now performs proper error checking and provides useful error
>> messages, so this -e option appears to be merely a historical artifact and
>> can be removed.
>
> Also, the MinGW port ignores -e on a #! line, so we should not rely on it.
>
>> --- a/git-request-pull.sh
>> +++ b/git-request-pull.sh
>> @@ -1,4 +1,4 @@
>> -#!/bin/sh -e
>> +#!/bin/sh
>
> To maintain the old behavior, I think we would need something like
> this:
>
> -- 8< --
> Subject: request-pull: more explicit error handling