git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jun 2, 2010, 14:21 UTC
Message-ID
<DuKPgjmjtglLvPhY13WXeTqBXfxpYQxJ0HN4KDdE6zz0PBeoa6gTbg@cipher.nrlssc.navy.mil>
In-Reply-To
<20100602043046.GB8245@progeny.tock>
On 06/01/2010 11:30 PM, Jonathan Nieder wrote:
Show 21 quoted lines
> Brandon Casey wrote:
> 
>> When git-request-pull was originally written, it did not do any error
>> checking and it used this shell feature to exit when an error occurred.
>> This script now performs proper error checking and provides useful error
>> messages, so this -e option appears to be merely a historical artifact and
>> can be removed.
> 
> Also, the MinGW port ignores -e on a #! line, so we should not rely on it.
> 
>> --- a/git-request-pull.sh
>> +++ b/git-request-pull.sh
>> @@ -1,4 +1,4 @@
>> -#!/bin/sh -e
>> +#!/bin/sh
> 
> To maintain the old behavior, I think we would need something like
> this:
> 
> -- 8< --
> Subject: request-pull: more explicit error handling
works for me.
Previous: Jonathan NiederNext: Junio C Hamano
Message 22 of 31 in “miscellaneous test suite fixes”
  1. 0/5 miscellaneous test suite fixesBrandon Casey, Jun 2, 2010
  2. 1/5 t/t5800: skip if python version is older than 2.5Brandon Casey, Jun 2, 2010
  3. Sverre RabbelierJun 2, 2010
  4. Ævar Arnfjörð BjarmasonJun 2, 2010
  5. Brandon CaseyJun 2, 2010
  6. Brandon CaseyJun 2, 2010
  7. Sverre RabbelierJun 2, 2010
  8. Brandon CaseyJun 2, 2010
  9. test suite work-around for python 2.5 requirementBrandon Casey, Jun 2, 2010
  10. 1/2 Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONSBrandon Casey, Jun 2, 2010
  11. 2/2 t/t5800: skip if python version is older than 2.5Brandon Casey, Jun 2, 2010
  12. Sverre RabbelierAug 17, 2010
  13. Jonathan NiederAug 17, 2010
  14. Sverre RabbelierAug 17, 2010
  15. Jonathan NiederAug 17, 2010
  16. Sverre RabbelierAug 18, 2010
  17. Brandon CaseyAug 18, 2010
  18. Johannes SixtJun 2, 2010
  19. Brandon CaseyJun 2, 2010
  20. 2/5 git-request-pull.sh: remove -e switch to shell interpreter which breaks kshBrandon Casey, Jun 2, 2010
  21. Jonathan NiederJun 2, 2010
  22. Brandon CaseyJun 2, 2010
  23. Junio C HamanoJun 2, 2010
  24. 3/5 t/t5150: remove space from sed scriptBrandon Casey, Jun 2, 2010
  25. Jonathan NiederJun 2, 2010
  26. 4/5 t/t7006: ignore return status of shell's unset builtinBrandon Casey, Jun 2, 2010
  27. Jonathan NiederJun 2, 2010
  28. Johannes SixtJun 2, 2010
  29. Brandon CaseyJun 2, 2010
  30. 4/5 t/t7006: ignore return status of shell's unset builtinBrandon Casey, Jun 2, 2010
  31. 5/5 t/aggregate-results: accomodate systems with small max argument list lengthBrandon Casey, Jun 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.