Re: [PATCH 1/5] t/t5800: skip if python version is older than 2.5
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jun 2, 2010, 06:37 UTC
- Message-ID
- <4C05FC18.4090402@viscovery.net>
- In-Reply-To
- <Wt_M4qptcPdpY0Q3jqUbfCU_HpY9NEjqs9eujZFD2rsUj5HRo__oQm7EUCxzXu38mC0y-ilUA14@cipher.nrlssc.navy.mil>
Am 6/2/2010 2:13, schrieb Brandon Casey:
> +if ! test_have_prereq PYTHON_2_5_OR_NEWER > then > + say 'skipping git remote-testgit tests: requires Python 2.5 or newer'
...
Show 9 quoted lines
> +++ b/t/test-lib.sh > +if test_have_prereq PYTHON && "$PYTHON_PATH" -c ' > +import sys > +if sys.hexversion < 0x02050000: > + sys.exit(1) > +' > +then > + test_set_prereq PYTHON_2_5_OR_NEWER > +fi
Please don't burden all test script invocations with this check when the result is used in only one place.
-- Hannes