Re: [PATCH] hooks: add signature to the top of the commit message
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Jul 1, 2017, 21:00 UTC
- Message-ID
- <A35B0D040EE544D8A7EA0B9A31E74F0D@PhilipOakley>
- In-Reply-To
- <xmqq37afoqa5.fsf@gitster.mtv.corp.google.com>
From: "Junio C Hamano" <gitster@pobox.com>
Show 29 quoted lines
> "Philip Oakley" <philipoakley@iee.org> writes: > >> From: "Junio C Hamano" <gitster@pobox.com> >>> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes: >>> >>>>> By the way, the one that is still actually enabled is no longer >>>>> needed. The commit template generated internally was corrected some >>>>> time ago not to add the "Conflicts:" section without commenting it >>>>> out. >>>>> >>>> I'll send in another patch that removes it but it seems removing it >>>> would leave sample hook without anything turned on by default. That >>>> doesn't sound fine, does it? >>> >>> Actually I was wondering if it is a good idea to remove it, as it >>> seems to have outlived its usefulness. >> >> Personally, I like the comfort of seeing the Conflicts: list, but if >> others have indicated otherwise... > > Oh, I think you misread the discussion while arriving from the > sideways. My "it" in the "remove it" refers to the sample > prepare-commit-msg hook; among the three examples in that hook, only > one of them is enabled but that one was to comment out the "Conflicts" > section in the log message editor. These days, that section already > appears in a commented-out form without the help of that hook, so > there is nothing useful in there---hence a suggestion for removal of > the sample. >
Thanks, yes I had misread it. I hadn't managed the time to follow the details. Problem solved.
Philip