[PATCH] hooks: replace irrelevant hook sample
- From
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
- Date
- Jul 5, 2017, 16:51 UTC
- Message-ID
- <20170705165114.20662-1-kaarticsivaraam91196@gmail.com>
- In-Reply-To
- <20170702112728.15757-1-kaarticsivaraam91196@gmail.com>
The pre-commit-msg hook sample has an example that comments the "Conflicts:" part of the merge commmit. It isn't relevant anymore as it's done by default since 261f315b ("merge & sequencer: turn "Conflicts:" hint into a comment", 2014-08-28).
Add an alternative example that replaces it. This ensures there's at the least a simple example that illustrates what could be done using the hook just by enabling it.
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> --- This one's the final proposed patch for this simple hook. I have requested for suggestions for alternative scripts in the mailing list[1]. In case something interesting turns out, we could use that instead of this one.
[1]: http://public-inbox.org/git/1499273152.16389.2.camel@gmail.com/T/#u
templates/hooks--prepare-commit-msg.sample | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/templates/hooks--prepare-commit-msg.sample b/templates/hooks--prepare-commit-msg.sample index 86b8f227e..0e2ccef11 100755 --- a/templates/hooks--prepare-commit-msg.sample +++ b/templates/hooks--prepare-commit-msg.sample @@ -9,8 +9,9 @@ # # To enable this hook, rename this file to "prepare-commit-msg". -# This hook includes three examples. The first comments out the -# "Conflicts:" part of a merge commit. +# This hook includes three examples. The first one removes three +# comment lines starting from the line that has the words +# "# Please enter the" in it's beginning. # # The second includes the output of "git diff --name-status -r" # into the message, just before the "git status" output. It is @@ -20,17 +21,20 @@ # The third example adds a Signed-off-by line to the message, that can # still be edited. This is rarely a good idea. -case "$2,$3" in - merge,) - @PERL_PATH@ -i.bak -ne 's/^/# /, s/^# #/#/ if /^Conflicts/ .. /#/; print' "$1" ;; +sed -e '/^# Please enter the .*/ { + N + N + d +}' "$1" >'.sed-output.temp' && mv '.sed-output.temp' "$1" +# case "$2,$3" in # ,|template,) # @PERL_PATH@ -i.bak -pe ' # print "\n" . `git diff --cached --name-status -r` # if /^#/ && $first++ == 0' "$1" ;; - - *) ;; -esac +# +# *) ;; +# esac # SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') # grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1"
-- 2.13.2.14.gb9bd03b20.dirty