Re: [PATCH 3/4] hook: add signature using "interpret-trailers"
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Jul 10, 2017, 15:13 UTC
- Message-ID
- <2e957be5-980b-1d7b-812f-bf18d12313d6@ramsayjones.plus.com>
- In-Reply-To
- <20170710141744.8541-3-kaarticsivaraam91196@gmail.com>
On 10/07/17 15:17, Kaartic Sivaraam wrote:
Show 14 quoted lines
> The sample hook to prepare the commit message before > a commit allows users to opt-in to add the signature > to the commit message. The signature is added at a place > that isn't consistent with the "-s" option of "git commit". > Further, it could go out of view in certain cases. > > Add the signature in a way similar to "-s" option of > "git commit" using git's interpret-trailers command. > > It works well in all cases except when the user invokes > "git commit" without any arguments. In that case manually > add a new line after the first line to ensure it's consistent > with the output of "-s" option. >
Again, s/signature/sign-off/g, or similar (including subject line).
ATB, Ramsay Jones
Show 20 quoted lines
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> > --- > templates/hooks--prepare-commit-msg.sample | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/templates/hooks--prepare-commit-msg.sample b/templates/hooks--prepare-commit-msg.sample > index 708f0e92c..a15d6d634 100755 > --- a/templates/hooks--prepare-commit-msg.sample > +++ b/templates/hooks--prepare-commit-msg.sample > @@ -32,4 +32,8 @@ SHA1=$3 > # esac > > # SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') > -# grep -qs "^$SOB" "$COMMIT_MSG_FILE" || echo "$SOB" >> "$COMMIT_MSG_FILE" > +# git interpret-trailers --in-place --trailer "$SOB" "$COMMIT_MSG_FILE" > +# if test -z "$COMMIT_SOURCE" > +# then > +# @PERL_PATH@ -i.bak -pe 'print "\n" if($first_line++ == 0)' "$COMMIT_MSG_FILE" > +# fi >