git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly

From
Blake Ramsdell <blaker@gmail.com>
Date
Nov 3, 2007, 00:21 UTC
Message-ID
<985966520711021721i6345e4bfv8a016a1528ee4e23@mail.gmail.com>
In-Reply-To
<7vbqacyyx1.fsf@gitster.siamese.dyndns.org>
On 11/2/07, Junio C Hamano <gitster@pobox.com> wrote:
> Does everybody's iconv use the same _LIBICONV_VERSION scheme?

Apparently not. And furthermore, my assumption about the version number being tied to the function prototype was not valid -- I have a DarwinPorts iconv.h that is version 0x010B but uses const for the second parameter.

Sorry for the mess. Let me try and come up with another plan. That Darwin version check doesn't seem so bad now ;).

Blake
-- 
Blake Ramsdell | http://www.blakeramsdell.com
Previous: Junio C Hamano
Message 15 of 15 in “Mac OS X 10.5 does not require the OLD_ICONV flag set”
  1. Mac OS X 10.5 does not require the OLD_ICONV flag setBlake Ramsdell, Nov 2, 2007
  2. Fixed a gcc 4.0.1 complaint about an uninitialized variableBlake Ramsdell, Nov 2, 2007
  3. Junio C HamanoNov 2, 2007
  4. Junio C HamanoNov 2, 2007
  5. Blake RamsdellNov 2, 2007
  6. Mike HommeyNov 2, 2007
  7. Benoit SIGOURENov 2, 2007
  8. Mike HommeyNov 2, 2007
  9. David SymondsNov 2, 2007
  10. Junio C HamanoNov 2, 2007
  11. David SymondsNov 2, 2007
  12. Blake RamsdellNov 2, 2007
  13. Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directlyBlake Ramsdell, Nov 3, 2007
  14. Junio C HamanoNov 3, 2007
  15. Blake RamsdellNov 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.