From: Blake Ramsdell Date: Sat, 03 Nov 2007 00:21:48 GMT Subject: Re: [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly Message-ID: <985966520711021721i6345e4bfv8a016a1528ee4e23@mail.gmail.com> In-Reply-To: <7vbqacyyx1.fsf@gitster.siamese.dyndns.org> On 11/2/07, Junio C Hamano wrote: > Does everybody's iconv use the same _LIBICONV_VERSION scheme? Apparently not. And furthermore, my assumption about the version number being tied to the function prototype was not valid -- I have a DarwinPorts iconv.h that is version 0x010B but uses const for the second parameter. Sorry for the mess. Let me try and come up with another plan. That Darwin version check doesn't seem so bad now ;). Blake -- Blake Ramsdell | http://www.blakeramsdell.com