Re: [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2007, 09:03 UTC
Message-ID: <7v4pg55893.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193971102-61907-1-git-send-email-blaker@gmail.com>

Blake Ramsdell <blaker@gmail.com> writes:

Show 20 quoted lines

> Signed-off-by: Blake Ramsdell <blaker@gmail.com>
> ---
>  Makefile |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 71479a2..5d83756 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -401,7 +401,9 @@ endif
>  ifeq ($(uname_S),Darwin)
>  	NEEDS_SSL_WITH_CRYPTO = YesPlease
>  	NEEDS_LIBICONV = YesPlease
> -	OLD_ICONV = UnfortunatelyYes
> +	ifneq ($(uname_R),9.0.0)
> +		OLD_ICONV = UnfortunatelyYes
> +	endif
>  	NO_STRLCPY = YesPlease
>  	NO_MEMMEM = YesPlease
>  endif

I do not have an access to a Darwin box, but do you mean 10.5 gives 9.0.0 as uname_R?