git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly

From
Blake Ramsdell <blaker@gmail.com>
Date
Nov 3, 2007, 00:00 UTC
Message-ID
<1194048010-65955-1-git-send-email-blaker@gmail.com>
In-Reply-To
<985966520711021303g905f638y2056219c22e5edeb@mail.gmail.com>
Signed-off-by: Blake Ramsdell <blaker@gmail.com>
---
 Makefile |    8 --------
 utf8.c   |    2 +-
 2 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index 71479a2..96c8a73 100644
--- a/Makefile
+++ b/Makefile
@@ -95,9 +95,6 @@ all::
 #
 # Define NO_ICONV if your libc does not properly support iconv.
 #
-# Define OLD_ICONV if your library has an old iconv(), where the second
-# (input buffer pointer) parameter is declared with type (const char **).
-#
 # Define NO_R_TO_GCC_LINKER if your gcc does not like "-R/path/lib"
 # that tells runtime paths to dynamic libraries;
 # "-Wl,-rpath=/path/lib" is used instead.
@@ -401,7 +398,6 @@ endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
-	OLD_ICONV = UnfortunatelyYes
 	NO_STRLCPY = YesPlease
 	NO_MEMMEM = YesPlease
 endif
@@ -657,10 +653,6 @@ ifdef NO_ICONV
 	BASIC_CFLAGS += -DNO_ICONV
 endif
 
-ifdef OLD_ICONV
-	BASIC_CFLAGS += -DOLD_ICONV
-endif
-
 ifdef PPC_SHA1
 	SHA1_HEADER = "ppc/sha1.h"
 	LIB_OBJS += ppc/sha1.o ppc/sha1ppc.o
diff --git a/utf8.c b/utf8.c
index 4efef6f..a7feb4f 100644
--- a/utf8.c
+++ b/utf8.c
@@ -300,7 +300,7 @@ int is_encoding_utf8(const char *name)
  * with iconv.  If the conversion fails, returns NULL.
  */
 #ifndef NO_ICONV
-#ifdef OLD_ICONV
+#if _LIBICONV_VERSION <= 0x0109
 	typedef const char * iconv_ibp;
 #else
 	typedef char * iconv_ibp;
-- 
1.5.3.GIT
Previous: Blake RamsdellNext: Junio C Hamano
Message 13 of 15 in “Mac OS X 10.5 does not require the OLD_ICONV flag set”
  1. Mac OS X 10.5 does not require the OLD_ICONV flag setBlake Ramsdell, Nov 2, 2007
  2. Fixed a gcc 4.0.1 complaint about an uninitialized variableBlake Ramsdell, Nov 2, 2007
  3. Junio C HamanoNov 2, 2007
  4. Junio C HamanoNov 2, 2007
  5. Blake RamsdellNov 2, 2007
  6. Mike HommeyNov 2, 2007
  7. Benoit SIGOURENov 2, 2007
  8. Mike HommeyNov 2, 2007
  9. David SymondsNov 2, 2007
  10. Junio C HamanoNov 2, 2007
  11. David SymondsNov 2, 2007
  12. Blake RamsdellNov 2, 2007
  13. Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directlyBlake Ramsdell, Nov 3, 2007
  14. Junio C HamanoNov 3, 2007
  15. Blake RamsdellNov 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.