git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] launch_editor(): indicate that Git waits for user input

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Nov 22, 2017, 17:58 UTC
Message-ID
<96f9c87c-d2c3-ebf3-bcca-da538c946733@gmail.com>
In-Reply-To
<998E3A52-C710-447A-82A3-50C58354CC31@gmail.com>
On Wednesday 22 November 2017 10:25 PM, Lars Schneider wrote:
Show 16 quoted lines
> 
>> On 20 Nov 2017, at 01:11, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
>>> It might be a good thing to keep the notice but I think it would be
>>> better to have that error message in a "new line". I'm not sure if
>>> it's possible or not.
>>
>> Of course it is possible, if you really wanted to.  The code knows
>> if it gave the "we launched and waiting for you" notice, so it can
>> maintain not just one (i.e. "how I close the notice?") but another
>> one (i.e. "how I do so upon an error?") and use it in the error
>> codepath.
> 
> I think a newline makes sense. I'll look into this for v3.
>

If I remember correctly, I don't think it's as simple as printing a newline character in case of an error. That's because the error message that shows up in the same line as "Launched your ..." comes from a different function (possibly finish_command() though I'm not sure)

> Thanks,
> Lars
>
Previous: Lars SchneiderNext: Junio C Hamano
Message 9 of 12 in “launch_editor(): indicate that Git waits for user input”
  1. launch_editor(): indicate that Git waits for user inputlars.schneider@autodesk.com, Nov 17, 2017
  2. Junio C HamanoNov 17, 2017
  3. Lars SchneiderNov 22, 2017
  4. Eric SunshineNov 17, 2017
  5. Junio C HamanoNov 18, 2017
  6. Kaartic SivaraamNov 19, 2017
  7. Junio C HamanoNov 20, 2017
  8. Lars SchneiderNov 22, 2017
  9. Kaartic SivaraamNov 22, 2017
  10. Junio C HamanoNov 24, 2017
  11. Lars SchneiderNov 22, 2017
  12. Eric SunshineNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.