From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Wed, 22 Nov 2017 17:58:55 GMT
Subject: Re: [PATCH v2] launch_editor(): indicate that Git waits for user input
Message-ID: <96f9c87c-d2c3-ebf3-bcca-da538c946733@gmail.com>
In-Reply-To: <998E3A52-C710-447A-82A3-50C58354CC31@gmail.com>

On Wednesday 22 November 2017 10:25 PM, Lars Schneider wrote:
> 
>> On 20 Nov 2017, at 01:11, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
>>> It might be a good thing to keep the notice but I think it would be
>>> better to have that error message in a "new line". I'm not sure if
>>> it's possible or not.
>>
>> Of course it is possible, if you really wanted to.  The code knows
>> if it gave the "we launched and waiting for you" notice, so it can
>> maintain not just one (i.e. "how I close the notice?") but another
>> one (i.e. "how I do so upon an error?") and use it in the error
>> codepath.
> 
> I think a newline makes sense. I'll look into this for v3.
>

If I remember correctly, I don't think it's as simple as printing a 
newline character in case of an error.  That's because the error message 
that shows up in the same line as "Launched your ..." comes from a 
different function (possibly finish_command() though I'm not sure)

> Thanks,
> Lars
>