Re: [PATCH v2] launch_editor(): indicate that Git waits for user input

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2017, 06:38 UTC
Message-ID: <xmqqk1ygnpu7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <998E3A52-C710-447A-82A3-50C58354CC31@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 7 quoted lines

>> Of course it is possible, if you really wanted to.  The code knows
>> if it gave the "we launched and waiting for you" notice, so it can
>> maintain not just one (i.e. "how I close the notice?") but another
>> one (i.e. "how I do so upon an error?") and use it in the error
>> codepath.
>
> I think a newline makes sense. I'll look into this for v3.

As this is an error codepath, I am OK to waste one more line with a line break after the "we launched and are waiting..." message, but with a shorter "we are waiting..." message, I do not know if it is bad enough to have these two on the same line, so I am on the fence.