git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 01/10] config: Codestyle cleanups.

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Feb 18, 2009, 09:18 UTC
Message-ID
<94a0d4530902180118j4746a690q7a42ea087e23488@mail.gmail.com>
In-Reply-To
<bd6139dc0902170833r7e6672f4p831dacb2ed841b32@mail.gmail.com>
On Tue, Feb 17, 2009 at 6:33 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 8 quoted lines
> On Tue, Feb 17, 2009 at 14:52, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> Did I miss 0/10 somehow? If not, it would be nice to have one if you
> send a long patch series :). That way I can ignore v3 of the series if
> the cover letter tells me nothing significant (to me) has changed. 1
> minutes to write for you, saves 5 minutes for all reviewers :).

Hmm, right. I was thinking on Junio and Johanness that already know the context, so they don't need an introduction, but I forgot about other people that might be interested in giving this a review.

In any case, this patch series is a try to re-organize the code of 'git config' and the main change is to use parseopt for better maintainability and option parsing. A few functionality changes are provided, like the fact that now the arguments don't need to be in a specific order: (--global -l vs -l --global), and improvements in error reporting. Otherwise it should work exactly the same as before (except with a much better --help).

Cheers.
-- 
Felipe Contreras
Previous: Sverre RabbelierNext: Junio C Hamano
Message 15 of 16 in “config: Codestyle cleanups.”
  1. 01/10 config: Codestyle cleanups.Felipe Contreras, Feb 17, 2009
  2. 02/10 config: Cleanup editor action.Felipe Contreras, Feb 17, 2009
  3. 03/10 config: Make git_config() more flexible.Felipe Contreras, Feb 17, 2009
  4. 04/10 config: Trivial rename in preparation for parseopt.Felipe Contreras, Feb 17, 2009
  5. 05/10 config: Reorganize get_color*.Felipe Contreras, Feb 17, 2009
  6. 06/10 config: Use parseopt.Felipe Contreras, Feb 17, 2009
  7. 07/10 config: Disallow --getcolor* and other actions.Felipe Contreras, Feb 17, 2009
  8. 08/10 config: Disallow multiple config file locations.Felipe Contreras, Feb 17, 2009
  9. 09/10 config: Disallow multiple variable types.Felipe Contreras, Feb 17, 2009
  10. 10/10 config: Don't allow extra arguments for -e or -l.Felipe Contreras, Feb 17, 2009
  11. Junio C HamanoFeb 18, 2009
  12. Felipe ContrerasFeb 18, 2009
  13. Junio C HamanoFeb 18, 2009
  14. Sverre RabbelierFeb 17, 2009
  15. Felipe ContrerasFeb 18, 2009
  16. Junio C HamanoFeb 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.