Re: [PATCH v3 03/10] config: Make git_config() more flexible

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 18, 2009, 21:13 UTC
Message-ID: <7viqn7v47s.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234878776-13250-3-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Currently git_config() returns an error if there is no repo config file
> available (cwd is not a git repo); it will correctly parse the system
> and global config files, but still return an error.

Currently it does???

Here is what I get from using the command from master and next:

    $ cd /var/tmp
    $ ls -d /.git /var/.git /var/tmp/.git /var/tmp/config
    ls: /.git: No such file or directory
    ls: /var/.git: No such file or directory
    ls: /var/tmp/.git: No such file or directory
    ls: /var/tmp/config: No such file or directory
    $ git config -l >/dev/null ; echo $?
    0
    $ git config alias.co; echo $?
    checkout
    0

I have $HOME/.gitconfig (where the alias comes from) and no system wide configuration file.

Also the patch is mistitled. Whatever you are trying to say about the current problem which I do not seem to get, and whatever different behaviour from the current one you are trying to implement (which is not quite clear from the above log message), it is not about making it more flexible.

The patch text suggests you are trying to change the function's exit status so the title would be "git-config: report errors correctly in its exit status", but it is unspecified in your commit log message what definition of "correctly" you are using in this patch.