From: Felipe Contreras Date: Wed, 18 Feb 2009 09:18:33 GMT Subject: Re: [PATCH v3 01/10] config: Codestyle cleanups. Message-ID: <94a0d4530902180118j4746a690q7a42ea087e23488@mail.gmail.com> In-Reply-To: On Tue, Feb 17, 2009 at 6:33 PM, Sverre Rabbelier wrote: > On Tue, Feb 17, 2009 at 14:52, Felipe Contreras > wrote: >> Signed-off-by: Felipe Contreras > > Did I miss 0/10 somehow? If not, it would be nice to have one if you > send a long patch series :). That way I can ignore v3 of the series if > the cover letter tells me nothing significant (to me) has changed. 1 > minutes to write for you, saves 5 minutes for all reviewers :). Hmm, right. I was thinking on Junio and Johanness that already know the context, so they don't need an introduction, but I forgot about other people that might be interested in giving this a review. In any case, this patch series is a try to re-organize the code of 'git config' and the main change is to use parseopt for better maintainability and option parsing. A few functionality changes are provided, like the fact that now the arguments don't need to be in a specific order: (--global -l vs -l --global), and improvements in error reporting. Otherwise it should work exactly the same as before (except with a much better --help). Cheers. -- Felipe Contreras