git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 01/10] config: Codestyle cleanups.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 18, 2009, 19:02 UTC
Message-ID
<7v8wo3y3eo.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<94a0d4530902180118j4746a690q7a42ea087e23488@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Hmm, right. I was thinking on Junio and Johanness that already know
> the context, so they don't need an introduction, but I forgot about
> other people that might be interested in giving this a review.

Also please don't assume anything about what other people may remember from your earlier series, after you received "this round is not ready to be applied because of this and that" comments. As far as the reviewer is concerned, that's the end of the story about the entire series, until you send a revised one. The reviewers are not promising to remember the fine details of the code and to help you improve the series, thinking about the series all the time until its next round materializes by reviewing the first round, and it is unrealistic to expect them to. There are a lot more patches and patch writers than there are people who review them.

The reason you are encouraged to say want was changed since the previous series when you are sending v(n+1) patch in each patch after three-dash lines is exactly because by default we expect reviewers remember nothing about the previous round and jogging their memory in such a way would help reviewing the new round.

Previous: Felipe Contreras
Message 16 of 16 in “config: Codestyle cleanups.”
  1. 01/10 config: Codestyle cleanups.Felipe Contreras, Feb 17, 2009
  2. 02/10 config: Cleanup editor action.Felipe Contreras, Feb 17, 2009
  3. 03/10 config: Make git_config() more flexible.Felipe Contreras, Feb 17, 2009
  4. 04/10 config: Trivial rename in preparation for parseopt.Felipe Contreras, Feb 17, 2009
  5. 05/10 config: Reorganize get_color*.Felipe Contreras, Feb 17, 2009
  6. 06/10 config: Use parseopt.Felipe Contreras, Feb 17, 2009
  7. 07/10 config: Disallow --getcolor* and other actions.Felipe Contreras, Feb 17, 2009
  8. 08/10 config: Disallow multiple config file locations.Felipe Contreras, Feb 17, 2009
  9. 09/10 config: Disallow multiple variable types.Felipe Contreras, Feb 17, 2009
  10. 10/10 config: Don't allow extra arguments for -e or -l.Felipe Contreras, Feb 17, 2009
  11. Junio C HamanoFeb 18, 2009
  12. Felipe ContrerasFeb 18, 2009
  13. Junio C HamanoFeb 18, 2009
  14. Sverre RabbelierFeb 17, 2009
  15. Felipe ContrerasFeb 18, 2009
  16. Junio C HamanoFeb 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.