From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Wed, 03 Jun 2015 07:33:20 GMT
Subject: Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits
Message-ID: <921357851.51732.1433316800782.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <vpqiob5fg24.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Ideally, you would check the list of commits displayed too. If the
> commits sha1 are stable, this should be easy to do. If it's too hard to
> test, I'd say its not worth the trouble, but others may disagree.

Originally I chose not to check if the SHA-1 were corrects since
check_commits was called right after expand_todo_ids and I thought
that expand_todo_ids checked them, but from what I understand, it
doesn't seem to check if the SHA-1 are commits, I could be wrong
though.

Rémi