git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] grep: fix builds with with no thread support

From
RBRahul Bedarkar <rahul.bedarkar@imgtec.com>
Date
Mar 20, 2017, 05:55 UTC
Message-ID
<91e0c631-1ce3-e76c-325b-fde0123c54b1@imgtec.com>
In-Reply-To
<20170317184155.128674-2-bmwill@google.com>
Hello,
On Saturday 18 March 2017 12:11 AM, Brandon Williams wrote:
Show 20 quoted lines
> Commit 0281e487fd91 ("grep: optionally recurse into submodules")
> added functions grep_submodule() and grep_submodule_launch() which
> uses "struct work_item" which is defined only when thread support
> is available.
>
> The original implementation of grep_submodule() used the "struct
> work_item" in order to gain access to a strbuf to store its output which
> was to be printed at a later point in time.  This differs from how both
> grep_file() and grep_sha1() handle their output.  This patch eliminates
> the reliance on the "struct work_item" and instead opts to use the
> output function stored in the output field of the "struct grep_opt"
> object directly, making it behave similarly to both grep_file() and
> grep_sha1().
>
> Reported-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  builtin/grep.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
>
It works for me.
Tested-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>

Thanks, Rahul

Previous: Jonathan NiederNext: Brandon Williams
Message 7 of 12 in “grep: fix build with no thread support”
  1. grep: fix build with no thread supportRahul Bedarkar, Mar 17, 2017
  2. Junio C HamanoMar 17, 2017
  3. Brandon WilliamsMar 17, 2017
  4. 1/2 grep: set default output methodBrandon Williams, Mar 17, 2017
  5. 2/2 grep: fix builds with with no thread supportBrandon Williams, Mar 17, 2017
  6. Jonathan NiederMar 17, 2017
  7. Rahul BedarkarMar 20, 2017
  8. Brandon WilliamsMar 17, 2017
  9. Jeff KingMar 17, 2017
  10. Brandon WilliamsMar 17, 2017
  11. Jeff KingMar 17, 2017
  12. Brandon WilliamsMar 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.