Re: [PATCH 2/2] grep: fix builds with with no thread support

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 17, 2017, 23:00 UTC
Message-ID: <20170317230000.GS26789@aiede.mtv.corp.google.com>
In-Reply-To: <20170317184155.128674-2-bmwill@google.com>

Brandon Williams wrote:

> Commit 0281e487fd91 ("grep: optionally recurse into submodules")
> added functions grep_submodule() and grep_submodule_launch() which
> uses "struct work_item" which is defined only when thread support

nit: which use (s/uses/use/)

> is available.

[...]

Show 5 quoted lines

> Reported-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  builtin/grep.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)

With or without that commit message tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.