From: Rahul Bedarkar Date: Mon, 20 Mar 2017 05:55:06 GMT Subject: Re: [PATCH 2/2] grep: fix builds with with no thread support Message-ID: <91e0c631-1ce3-e76c-325b-fde0123c54b1@imgtec.com> In-Reply-To: <20170317184155.128674-2-bmwill@google.com> Hello, On Saturday 18 March 2017 12:11 AM, Brandon Williams wrote: > Commit 0281e487fd91 ("grep: optionally recurse into submodules") > added functions grep_submodule() and grep_submodule_launch() which > uses "struct work_item" which is defined only when thread support > is available. > > The original implementation of grep_submodule() used the "struct > work_item" in order to gain access to a strbuf to store its output which > was to be printed at a later point in time. This differs from how both > grep_file() and grep_sha1() handle their output. This patch eliminates > the reliance on the "struct work_item" and instead opts to use the > output function stored in the output field of the "struct grep_opt" > object directly, making it behave similarly to both grep_file() and > grep_sha1(). > > Reported-by: Rahul Bedarkar > Signed-off-by: Brandon Williams > --- > builtin/grep.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > It works for me. Tested-by: Rahul Bedarkar Thanks, Rahul