Re: [PATCH] grep: fix build with no thread support

From: Brandon Williams <bmwill@google.com>
Date: Mar 17, 2017, 18:47 UTC
Message-ID: <20170317184701.GB110341@google.com>
In-Reply-To: <xmqqy3w37ptd.fsf@gitster.mtv.corp.google.com>

While taking a look at this bug I discovered that the test suite doesn't pass 100% of the test when compiled with the NO_PTHREADS option. The following tests seem to be failing:

t1060-object-corruption.sh                       (Wstat: 256 Tests: 13 Failed: 3)
  Failed tests:  7-9
  Non-zero exit status: 1
t5306-pack-nobase.sh                             (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
t5504-fetch-receive-strict.sh                    (Wstat: 256 Tests: 12 Failed: 2)
  Failed tests:  4-5
  Non-zero exit status: 1
t5530-upload-pack-error.sh                       (Wstat: 256 Tests: 10 Failed: 1)
  Failed test:  10
  Non-zero exit status: 1

I didn't take a close look at it but this would seem to indicate that we don't worry to much about systems without pthreads support. Just food for thought.

-- 
Brandon Williams