git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] t/t1304: use 'test -r' to test readability rather than looking at mode bits

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Mar 15, 2010, 17:51 UTC
Message-ID
<8fqqfdxYYa4RPD7FGUikyKCKHtfa5A5dhaSpyecsKHixseAVhiHOyw@cipher.nrlssc.navy.mil>
In-Reply-To
<vpq3a017am6.fsf@bauges.imag.fr>
On 03/15/2010 12:33 PM, Matthieu Moy wrote:
Show 11 quoted lines
> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> -	-r--r-----*)
>> -		: happy
>> -		;;
> 
>> +	test -r "$1" &&
> 
> Maybe it makes sense to ask for -r--?-----* instead, to make sure we
> don't give the read bit to anyone. But that's not really important
> since we're protected by the directory's permission anyway.

I'm a little hesitant to add a test on the output from 'ls', since Solaris and Linux produce different output in the presence of ACL's.

-brandon
Previous: Matthieu MoyNext: Brandon Casey
Message 6 of 12 in “tweak t1304 ACL tests so they work on Solaris”
  1. 0/5 tweak t1304 ACL tests so they work on SolarisBrandon Casey, Mar 15, 2010
  2. 1/5 t/t1304: avoid -d option to setfaclBrandon Casey, Mar 15, 2010
  3. 2/5 t/t1304: set the Default ACL base entriesBrandon Casey, Mar 15, 2010
  4. 3/5 t/t1304: use 'test -r' to test readability rather than looking at mode bitsBrandon Casey, Mar 15, 2010
  5. Matthieu MoyMar 15, 2010
  6. Brandon CaseyMar 15, 2010
  7. 4/5 t/t1304: set the mask ACL that is checked in check_perms_and_aclBrandon Casey, Mar 15, 2010
  8. Matthieu MoyMar 15, 2010
  9. Brandon CaseyMar 15, 2010
  10. 4/5 t/t1304: set the ACL effective rights maskBrandon Casey, Mar 15, 2010
  11. Matthieu MoyMar 15, 2010
  12. 5/5 t/t1304: make a second colon optional in the mask ACL checkBrandon Casey, Mar 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.