From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Mon, 15 Mar 2010 17:51:24 GMT
Subject: Re: [PATCH 3/5] t/t1304: use 'test -r' to test readability rather than looking at mode bits
Message-ID: <8fqqfdxYYa4RPD7FGUikyKCKHtfa5A5dhaSpyecsKHixseAVhiHOyw@cipher.nrlssc.navy.mil>
In-Reply-To: <vpq3a017am6.fsf@bauges.imag.fr>

On 03/15/2010 12:33 PM, Matthieu Moy wrote:
> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> -	-r--r-----*)
>> -		: happy
>> -		;;
> 
>> +	test -r "$1" &&
> 
> Maybe it makes sense to ask for -r--?-----* instead, to make sure we
> don't give the read bit to anyone. But that's not really important
> since we're protected by the directory's permission anyway.

I'm a little hesitant to add a test on the output from 'ls', since
Solaris and Linux produce different output in the presence of ACL's.

-brandon