[PATCH 2/5] t/t1304: set the Default ACL base entries
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Mar 15, 2010, 17:14 UTC
- Message-ID
- <YowxgPZqaOkg2MZzY1CxL62AYRaulAaBTuVJyBy21GtGshrh3yFvpwnH4N2NnyXFt4HiCe6vR8E@cipher.nrlssc.navy.mil>
- In-Reply-To
- <YowxgPZqaOkg2MZzY1CxL1fbmUZ7CMUf5DgqI3S0X83DgqLNI9AGfI83JRNT8LWYHqXBB-PGS1Q@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>
According to the Linux setfacl man page, in order for an ACL to be valid, the following rules must be satisfied:
* Whenever an ACL contains any Default ACL entries, the three Default
ACL base entries (default owner, default group, and default others)
must also exist. * Whenever a Default ACL contains named user entries or named group
objects, it must also contain a default effective rights mask.Some implementations of setfacl (Linux) do this automatically when necessary, some (Solaris) do not. Solaris's setfacl croaks when trying to create a default user ACL if the above rules are not satisfied. So, create them before modifying the default user ACL's.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> --- t/t1304-default-acl.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh index 415a2dd..3a1532b 100755 --- a/t/t1304-default-acl.sh +++ b/t/t1304-default-acl.sh @@ -45,6 +45,7 @@ check_perms_and_acl () { dirs_to_set="./ .git/ .git/objects/ .git/objects/pack/" test_expect_success 'Setup test repo' ' + setfacl -m d:u::rwx,d:g::---,d:o:---,d:m:rwx $dirs_to_set && setfacl -m u:root:rwx $dirs_to_set && setfacl -m d:u:"$LOGNAME":rwx $dirs_to_set && setfacl -m d:u:root:rwx $dirs_to_set &&
-- 1.6.6.2